Repository navigation
feat: modern event subsystem - #1945
Open
mdjastrzebski wants to merge 5 commits into
Open
mdjastrzebski wants to merge 5 commits into
mdjastrzebski wants to merge 5 commits into
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if (Object.hasOwn(target, key) && isObject(sourceValue) && isObject(targetValue)) { | ||
| mergeInto(targetValue, sourceValue); | ||
| } else { | ||
| target[key] = sourceValue; |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1945 +/- ##
==========================================
+ Coverage 98.56% 98.93% +0.36%
==========================================
Files 87 103 +16
Lines 1744 2254 +510
Branches 459 597 +138
==========================================
+ Hits 1719 2230 +511
+ Misses 24 23 -1
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mdjastrzebski
force-pushed
the
next/event-system
branch
from
October 12, 2026 10:58
0b69f6b to
b561465
Compare
mdjastrzebski
marked this pull request as ready for review
October 13, 2026 20:28
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Merges the
next/event-systemfeature branch (#1944, #1946) intomain.Adds an
'modern'event system forfireEventanduserEvent, opt-in withconfigure({ unstable_eventSystem: 'modern' }). It follows React Native's event dispatch: handlers receive aSyntheticEvent, and events bubble or go direct like on a device.fireEvent, includingfireEvent.press(), which calls the press callback of the element that becomes the touch responder (Pressable,Touchable*).userEvent.press()/longPress()with it, so both press the same element.'legacy'stays the default and behaves as before. Its code moves tosrc/events/legacy/, with code used by both systems insrc/events/shared/.legacyandmodernprojects) against shared snapshots.Test plan
yarn validate(typecheck, tests in both Jest projects, lint, format check): 184 suites, 2278 tests, 518 snapshots passed.